Improve error message when CMake is not found #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apartridge
approved these changes
Dec 10, 2024
| raise RuntimeError( | ||
| _make_message_box( | ||
| "!! CMake not found !!", | ||
| "Ensure PIP is updated to the latest version to handle build dependencies automatically,", |
There was a problem hiding this comment.
LGTM, I would consider to prefix this with "Tip:" and maybe some blank lines before and after just so this part is more visibile. Often people get overwhelmed by long error messages and won't see the tips/solution.
There was a problem hiding this comment.
It will look like this:
johningve
deleted the
MISC-2024-12-10-improve-cmake-not-found-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.